feat(tokio_util): Stabilise JoinMap #7075
Open
+22
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
force-pushed
the
conrad/stabalise-joinmap
branch
2 times, most recently
from
eb9f646 to
5155239
Compare
conradludgate
changed the title
conradludgate
force-pushed
the
conrad/stabalise-joinmap
branch
from
5155239 to
91695b2
Compare
Darksonn
reviewed
Jan 6, 2025
| @@ -43,8 +43,6 @@ futures-util = { version = "0.3.0", optional = true } | |||
| pin-project-lite = "0.2.11" | |||
| slab = { version = "0.4.4", optional = true } # Backs `DelayQueue` | |||
| tracing = { version = "0.1.29", default-features = false, features = ["std"], optional = true } | |||
|
|
|||
| [target.'cfg(tokio_unstable)'.dependencies] | |||
| hashbrown = { version = "0.14.0", default-features = false, optional = true } | |||
There was a problem hiding this comment.
Hmm. I'll have to think about what implications this has for our MSRV.
There was a problem hiding this comment.
hashbrown 0.14.0 has a rust-version = "1.64.0".
hashbrown 0.15.2 has a rust-version = "1.65.0".
It doesn't seem to have an explicit MSRV policy, but it is inline with tokio-util's 1.70.0
There was a problem hiding this comment.
I'm okay with this, but I don't want to require hashbrown if you're just using the TaskTracker. Can you add a join_map feature?
There was a problem hiding this comment.
That seems reasonable. Will do
Darksonn
changed the title
Darksonn
reviewed
Jan 8, 2025
tokio-util/src/task/join_map.rs
Outdated
Comment on lines
103
to
99
| #[cfg_attr(docsrs, doc(cfg(all(feature = "rt", tokio_unstable))))] | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "rt")))] | ||
| pub struct JoinMap<K, V, S = RandomState> { |
There was a problem hiding this comment.
Once you add the join_map feature, this annotation may not be necessary. Please try removing it and checking the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The other day I saw someone asking for JoinMap to be stabalised. I happened to notice just now that the task ID system is now stable in tokio.
Solution
Removes the unstable config requirement for
tokio_util::JoinMap.